You would not be disappointed with the diving in Santorini. (We also dive in Grand Cayman, Cozumel, Costa Rica, etc.) The only caveat is the water temp, even in the dead of summer they dive with 5mm suits.
The island itself is amazing, just idyllic scenery everywhere. The food is also...