So, you want shore diving aside from Bonaire & Curacao, both of which you've already done, presumably Caribbean. Well, Grand Cayman, Roatan's CocoView Resort and St. Croix are the 2 options that leap to mind.
There are enough threads on Cayman diving, I imagine you can do a forum search and read up on shore sites; I recall hearing of Cobalt Coast's house reef, Lighthouse Point, Turtle Reef, Sunset House's house reef and despite some major damage from a ship basically crashing into the area, Eden Rock/Devil's Grotto. So there are sites to hit.
Likewise, CocoView Resort on Roatan has a large following and you can read plenty about that. When reading about Roatan, note one knowledgeable forum member has explained in some threads how the diving differs markedly depending on which coast you dive off of. And shore diving isn't readily accessible to all locations, hence my specifying CocoView Resort.
St. Croix has what I take to be a smaller but loyal following. I've collected a pretty good pile of research notes in preparation for a trip I hope to make later this summer; shoot me a 'Conversation' and I can send you a rough draft if you have a strong interest ( don't want to post an incomplete draft when I hope to dive the place personally this year). A lot depends on what part of St. Croix you want to stay at.
Cruise ships stop at Frederiksted Pier, a very popular dive site you can't dive with a cruise ship in, but it's not a real busy cruise stop. California Diver Magazine just posted
an extensive article on this site. St. Croix's west coast is leeward and features calm conditions much of the time. But you're not looking at a bunch of shore diving sites.
If you stay at the 'busy' (still small) city of Christiansted, you might consider St. Croix Ultimate Blue Water Adventure, located by Hotel Caravelle, but Christiansted itself is not a shore dive site.
Cane Bay Dive Shop has some affiliated cottages, or you could stay at nearby Arawak Inn; I've read the swim out for shore diving at Cane Bay can be substantial; in another thread forum member dfx wrote:
Shore diving is very limited in St Croix. We did a shore dive at Cane Bay, but the swim out was very long so we didn't do that a second time.
From what I've read a number of people like shore diving there, but be aware of the swim out.
Not far away is Davis Bay; you might check out the offerings by Sweet Bottom Dive Center, located at the St. Croix Renaissance Carambola Beach Resort & Spa. I can't give you exact comparisons on swim out, but I've inferred (correctly, I hope!) it's shorter than Cane Bay?
Anyone who's done both care to comment?
Richard.
Note: I love shore diving, but I'd be hesitant to pick any of those 3 destinations for
only shore diving. I think you'll going to miss out on some good diving if you don't hit a boat at least some.