Thanks everyone for your suggestions. I am itching to go to Cocos and Galapagos but given the perspective I think it is a good idea to wait until I have more dives under my belt. And I had no idea that the pyramids weren't near the dive sites but that makes sense now.
I do have a dive buddy (my bf) and he wants to avoid Egypt because he thinks it's still too unsafe although I am not worried about that issue.
I was just recommended Kapalai Island in Borneo Malaysia.
And to Doc, no this isn't a final dive and there isn't an unlimited budget. If that were the case I wouldn't be asking, I would just fly around the world in a private jet and dive every dive site. I was simply trying to find out where people had their best dives and would always recommend. If you could go anywhere in the world for two weeks in April where would you go back to? That's all that I am asking. I find that personal recommendations are much better and thorough than a google search.
Thanks everyone for the feedback, I am hearing a lot about the Philippines so I will have to look into that further!
I hope that you find a great destination, let us know what you decide. One of the reasons that I mentioned Egypt is because it would be somewhat easy to get there from New York; be sure to figure in lots of travel time (and jet lag!) into a far away destination. It may take a day or two to get there (and back) and it might be a different calendar day when you arrive and you will likely be beat when you do.
I'm not saying don't do it, just plan it into your trip and allow time for travel and fatigue. You won't be flying direct for half a day, jumping off the plane, breezing though I&C, and then heading out to the reef, like you can at some of the nearer, less exotic destinations.
Also, after you make your plans be sure to buy travel insurance and DAN dive insurance. A trip like that is a major expenditure of both time and money and you will want to have some options if things don't work out exactly as planned. I don't mean to sound like a Debbie Downer, but right now I am thinking of all the recent hurricane and typhoon activity in the Atlantic, Caribbean, and the Pacific. Although you will be traveling in April so I don't think that will be a problem.
But keep in mind that in some parts of the world the high season for vacation travel extends into at least mid-April, and Easter Sunday will be April 21, 2019 - so that may be a popular holiday travel week in the US and some foreign locations.
If you could push the date to early May you might find cheaper, less crowded options, but again that really depends on the destination you pick. For example, the Philippines are a Christian country so Easter may be a popular time for local travelers but Islam is the official religion of Malaysia, so Easter travel may not be a significant factor there.
Have fun!