It is all a personal choice as to whether they work or not. I do not use them because I have only ever had problems clearing once and that took all of about 1 minute to overcome. HOWEVER, I do know of several people that dive with them, my significant other as one. She used to take upwards of 5 minutes to get through the first 20-30 feet of water because her ears hurt some much. With the Doc Pro Plugs vented for divers, this trip usually now takes less than a minute. She loves them because they work almost perfectly for her. She has lost several pair as another poster mentioned. This was frustrating but when she bought them with the lanyard, if they fell out after the dive, the lanyard caught on her hair or tank and I was able to get them so they did not get lost. If you feel that is too much of an inconvenience, then they are not for you (with a lanyard).
Seeing the improvement for those that I know, I have no problem suggesting to anybody that they at least try them out. If you do not like them, then you are not out much money. If you do, your diving becomes so much easier and pleasurable that you will wonder why you did not get them earlier.