Large Bags, cases, and boxes are a real pain on boats where space is always a premium.
As a general rule, The Stab' Jacket and regulators will be on the cylinder, so they don't need storage.
You will need a bag to keep the smaller stuff together, fins, mask, reels, DSMB etc. Weights carry separately - they will break most bags - its easier and safer.
Generally avoid bags with zips. Zips and seawater don't mix (although they will last a trip). As stated above, a string bag - its cheap and nothing much to go wrong. I add a clip to mine then I can clip it off to the cylinder or boat rail - stops it going missing and keeps it off the deck. (I always clip to the rail when its empty, then I can find it again when I return from the dive).
I make a point of putting my stuff back in the bag as soon as possible once I get back on the boat and de-kitted - even before drinking my tea! It ensures you don't loose stuff and aren't running around the boat looking for your missing mask just before the next dive. It also stops people sitting on your mask or dropping cylinders on your kit. On that note, either wear your computer all the time or clip it back on your Stab jacket, I've seen to many with cylinders on them or kicked over the side by accident.
A small dry bag is always handy for your phone, wallet, sunblock, etc.
Cameras - I was taught a good trick this year. I've started to use a small coolbox. It takes the camera, the wet lenses, strobe etc all assembled. It keeps the camera and lenses cool (stops lenses fogging issues), it doesn't look like expensive camera gear when in the car. It doesn't matter when you drop a wet camera back in the box. Its light, easy to clean and wash, drys quickly and is robust enough to protect the camera.
If you are on a live aboard. Then larger bags are good to get kit on to the boat. One for dive kit, one (or two) for dry. If they are bags they can be folded up taking the minimum of space and are easy to store.
Gareth