+1 on the intrinsic link between course value and instructor knowledge/motivation/teaching skill. That's the crux factor that determines whether any course is enjoyable and beneficial for the diver. Underwater basket weaving is a laughable example, but in all honesty, a great instructor is still going to make that into a great course...and vice versa.
Every scuba course should develop core diving skills - buoyancy, gas management, equipment familiarisation, self-sufficiency and risk awareness.
Every scuba course should be flexible enough to identify and address specific diver needs and rectify skill deficits.
Every scuba course should improve overall situational awareness, multi-tasking, stress management and increase a divers' comfort zone.
I believe that there are three different forms of course; those that address core scuba development, specific scuba development and those that satisfy specialist diver interests. Sometimes those goals/benefits will overlap - especially when a good instructor is teaching.
Here's how I break down the course types;
1) General core development courses; PPB, Navigation, Deep, S&R, Night, ML
These courses contribute directly towards your overall scuba diving competency. They develop, extend and refine core scuba skills taught at OW level for the purposes of increasing safety, confidence and competence for general scuba diving activities. They don't provide specific 'new' specialist skills, but rather develop existing skills and knowledge on core issues to a higher level.
It could be easy to assess these as 'valueless' depending upon your own self-assessment of your skills/level. If a diver has a high value on their own core skills, then they may perceive they have little to gain from this form of training. However, to do so implies that the diver also feels that they have reached some form of 'skill pinnacle' and consequently, doesn't feel that further personal development is possible. Any truly experienced diver will know that this 'skill pinnacle' never exists - it's just a matter of perspective and which peer group your judge yourself against. Any diver who feels they cannot develop more has obviously 'outgrown' the pond they currently swim in.
The key to value in a general core development course is to find an instructor with the background, experience and capability to take you beyond your current level. In short - find someone who 'swims in a bigger pond' than yourself. This is the process of transitioning into being a smaller fish in a bigger pond.
Note: The benefits of this are dependant on the instructor having the background/skills/knowledge to take you to a higher level - many don't. The 'average' Open Water scuba instructor spends most of their time teaching basic OW diving and, thus is an expert within a very confined skill-set..."a big fish in a small pond".
2) Regional/Environmentally specific skill development courses; Drysuit, Ice, Altitude, Cavern, Wreck, Drift
These courses teach 'core skills' that have specific relevance to certain diving environments. They aren't globally relevant, but are critical for specific regional and/or activity based diving habits. The courses should always be taken in the same environment/location as they will be used in. They should also be taken with instructors who have amassed a great amount of experience in that specific environment/location and, therefore, developed a very high standard of appropriate skill and knowledge that is specifically applicable to the course and the divers' needs.
These courses are necessary because the 'mainstream' recreational diving courses (OW-AOW-RESCUE) are globally relevant and do not include specific skills and knowledge at a regional level. Whilst any diver can attain regional knowledge through safe, progressive application of 'mainstream' training within a given environment - there is always a logical argument that expert tuition is a foolproof 'fast track' to competence.
Note: The benefits of this are dependant on the instructor having the background/skills/knowledge in regionally/environmental specific techniques and procedures. These courses cannot be taught well as generic 'one-size-fits-all' training programmes. However, many agencies don't qualify instructors on this basis - which can lead to bland, unfulfilling courses being taught.
3) Specialist interest courses; Fish ID, Photo, Equipment, Coral Reef Conservation, Lionfish hunter, etc etc
These courses deal with specific subject matters that may be of interest to specific divers. The value in these courses is primarily dictated by the interest of the student, rather than any over-arching development as a scuba diver. Naturally, any instructor teaching these courses should be a 'subject matter expert' in the course concerned. Only then can the topic be presented with the depth, clarity and motivation that will make the training enjoyable and beneficial to the student. In addition, a 'good' instructor will also use these training courses as an opportunity to develop the overall skills and capability of the student. Most special interest dive activities demand competency in core scuba techniques and these should be appropriately addressed as part of the training.
Note: The benefits of this are dependant on two factors. First, that the student is genuinely interested and motivated in the topic. Second, that the instructor is a motivated 'subject matter expert' on the topic. If either of these criteria are lacking, then the course is likely to fail to achieve its potential. These courses are often sold as 'fillers' or provided by instructors who have no real interest in the subject. Hence, they are badly regarded by many divers and instructors alike.